Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider composer validation commands #125

Open
internalsystemerror opened this issue Aug 23, 2022 · 4 comments
Open

Consider composer validation commands #125

internalsystemerror opened this issue Aug 23, 2022 · 4 comments
Assignees

Comments

@internalsystemerror
Copy link
Member

internalsystemerror commented Aug 23, 2022

Feature Request

Q A
New Feature yes
RFC yes
BC Break yes/no maybe?

Summary

  1. Run composer validate to confirm that there are no issues with the composer.json file.
  2. Run composer check-platform-reqs, at least where --ignore-platform-reqs is not used in order to confirm that the installed packages should function correctly.
  3. Run composer audit to get a list of the vulnerable packages (if any) as the warning on install just lists the number of vulnerable packages, not what they are https://github.com/laminas/laminas-cli/runs/8005445567?check_suite_focus=true#step:3:315
@Ocramius
Copy link
Member

Prior to running composer install

I really want this sort of stuff in independent jobs, not in "before" or "after" scripts.

Having to jump in a failed PHPUnit job because something completely unrelated failed is no fun :D

@internalsystemerror
Copy link
Member Author

Good idea, I should probably transfer this to the matrix action repository.

@internalsystemerror internalsystemerror transferred this issue from laminas/laminas-continuous-integration-action Aug 23, 2022
@internalsystemerror
Copy link
Member Author

internalsystemerror commented Aug 25, 2022

Hmmm... My original thoughts for adding this to the integration action are because if composer install fails, I'm not sure it will then proceed to composer validate in order to get more information as to why it failed. But the information given is an assumption, I intend to do some testing to see what benefits composer validate could bring us over a simple install.

As it relates to the composer check-platform-reqs command, having this as a separate job would mean that a new job would need to be created for each option in the matrix (7.4-lowest, 7.4-latest, 7.4-locked, 8.0-lowest, 8.0-latest, 8.1-lowest, 8.1-latest).

@internalsystemerror internalsystemerror changed the title Consider composer validate and composer check-platform-reqs Consider composer validation commands Aug 25, 2022
@internalsystemerror
Copy link
Member Author

internalsystemerror commented Aug 25, 2022

Also adding composer audit for consideration (issue description updated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants