expect(!2xx) throws exception

[midrissi]

I have migrated to the latest version of supertest (4.0.0), but all my tests that expect a status code different to 2xx fails.

Example:

const request = require('supertest');
const express = require('express');

const app = express();

app.get('/user', function (req, res) {
  res.status(404).end();
});

(async () => {
  await request(app)
    .get('/user')
    .expect(404)
    .send({ hello: 'hi' })
})();

Will throw an Error: Not Found exception.

[midrissi]

A simple test case:

it('should assert using promises', function (done) {
  const app = express();

  app.get('/', function (req, res) {
    res.status(400).end();
  });

  request(app)
    .get('/')
    .expect(400)
    .then(done)
    .catch(done);
});

[Jackie-Tan]

Updated: revert to v3.4.2. Everything back to normal.

I have similar issue too.
My code:

const request = require('supertest');
const express = require('express');

const app = express();

app.get('/user', function (req, res) {
  res.status(400).send();
});

test('Should pass this test with status 400', async () => {
	await request(app).get('/user').expect(400)
})

Expect the test to pass, but instead:

 FAIL  tests/testing.test.js
  ● Should pass this test with status 400

    Bad Request

      at Test.Object.<anonymous>.Request.callback (node_modules/superagent/lib/node/index.js:804:15)
      at IncomingMessage.parser (node_modules/superagent/lib/node/index.js:1036:18)

[kevinbosman]

This is the same issue as #534, which was caused by upgrading superagent to v4.1.0. This previous issue was resolved at the time by downgrading superagent to v3.8.3.

superagent has again been upgraded without a proper fix in place.

[ahce]

async and promises are broken
Only works this:

request(app)
    .get('/')
    .expect(400)
    .end(done);

[bonesoul]

same here.

[rimiti]

@gjohnson Do you have some time for fixing that? 🙏

[posquit0]

same here

[fega]

Same here, I'm not sure if this change was intented, but a !2XX response shouldn't trigger a failure

[jbinto]

Worth following upstream: ladjs/superagent#1466

[gjohnson]

@rimiti looking at this right now - these reports are much clearer @midrissi.

[jsstrn]

Thanks for reporting the issue. While we are waiting for a fix, we can use this technique to resolve it:

it("should return status code 400", () => {
  return request(app)
    .get("/")
    .catch(res => {
      expect(res.status).toBe(400);
    });
});

Or, with async/await:

it("should return status code 400", async () => {
  await request(app)
    .get("/")
    .catch(res => {
      expect(res.status).toBe(400);
    });
});

[rimiti]

#558 merged, I close this issue.

Thank you 🙏