Fix rate limiter docs #2366
Merged
Fix rate limiter docs #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds ok to me. Add it to this PR and I'll merge it. |
What does this mean? This document is in the different repository from this one, so I think we need to create a new PR about document fixing on this repo. |
|
silly me. sorry, my bad. I was distracted yesterday and forgot what repo this was and where there docs are located. Just create PR at echox. Thanks! |
|
No problem. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1853
What I did
rate_limiter.goWhy
middleware.NewRateLimiterMemoryStorewhen the argument is a float number.Need to do