Add new method HTTPError.WithInternal #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.37% // Head: 92.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2340 +/- ##
==========================================
+ Coverage 92.37% 92.38% +0.01%
==========================================
Files 37 37
Lines 4448 4454 +6
==========================================
+ Hits 4109 4115 +6
Misses 247 247
Partials 92 92
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aldas
force-pushed
the
httperror_withinternal
branch
from
36c3eaf
to
be420bf
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new method HTTPError.WithInternal to be able to create clone of HTTPError with given error set as internal
Currently HTTPError has method
SetInternalbut this mutates that same error which is problematic when we use those public errors we have alaecho.ErrUnauthorizedetc. For these cases creating clone of that error instance is better.