Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests #2275

Merged
merged 14 commits into from Oct 6, 2022
Merged

update tests #2275

merged 14 commits into from Oct 6, 2022

Conversation

Kamandlou
Copy link
Contributor

No description provided.

@Kamandlou
Copy link
Contributor Author

@vishr

context.go Outdated Show resolved Hide resolved
bind_test.go Outdated Show resolved Hide resolved
@Kamandlou Kamandlou changed the title rename variable because collides with imported package name update tests Oct 6, 2022
@Kamandlou Kamandlou requested a review from aldas October 6, 2022 07:36
bind_test.go Outdated Show resolved Hide resolved
@Kamandlou
Copy link
Contributor Author

Kamandlou commented Oct 6, 2022

There are two left assert.New because assertBindTestStruct function and because we can't use generic

@Kamandlou Kamandlou requested a review from aldas October 6, 2022 08:00
bind_test.go Outdated Show resolved Hide resolved
@Kamandlou Kamandlou requested a review from aldas October 6, 2022 08:15
Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas aldas merged commit 4c44305 into labstack:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants