Timeout mw: rework how test waits for timeout. Using sleep as delay i… #2187

aldas · 2022-05-21T19:53:45Z

Timeout mw: rework how test waits for timeout. Using sleep as delay is problematic when CI worker is slower than usual. Also make sure we wait logger middleware to be actually executed before we start asserting logger buffer contents.

Still having problems with macos-latest @ Go 1.18 runs

2022-05-21 19:29:13.081172 +0000 UTC m=+0.616594200
--- FAIL: TestTimeoutWithFullEchoStack (0.14s)
    --- FAIL: TestTimeoutWithFullEchoStack/503_-_handler_timeouts,_write_response_in_timeout_middleware (0.08s)
        timeout_test.go:417: 
            	Error Trace:	timeout_test.go:417
            	Error:      	Should be false
            	Test:       	TestTimeoutWithFullEchoStack/503_-_handler_timeouts,_write_response_in_timeout_middleware

…s problematic when CI worker is slower than usual.

Timeout mw: rework how test waits for timeout. Using sleep as delay i…

a9c75d5

…s problematic when CI worker is slower than usual.

aldas force-pushed the fix_timeout_mw_fullstack_test branch from 051080b to a9c75d5 Compare May 21, 2022 20:36

Timeout mw: rework how test waits for timeout. Using sleep as delay i…

2768448

…s problematic when CI worker is slower than usual.

aldas merged commit d5f8837 into labstack:master May 21, 2022

aldas deleted the fix_timeout_mw_fullstack_test branch July 12, 2022 19:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Timeout mw: rework how test waits for timeout. Using sleep as delay i… #2187

Timeout mw: rework how test waits for timeout. Using sleep as delay i… #2187

aldas commented May 21, 2022 •

edited

Timeout mw: rework how test waits for timeout. Using sleep as delay i… #2187

Timeout mw: rework how test waits for timeout. Using sleep as delay i… #2187

Conversation

aldas commented May 21, 2022 • edited

aldas commented May 21, 2022 •

edited