Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix syntax #1994

Merged
merged 1 commit into from Jan 24, 2022
Merged

fix syntax #1994

merged 1 commit into from Jan 24, 2022

Conversation

sivchari
Copy link
Contributor

I'm sorry for giving you a PR with only a few adjustments.
I fixed syntax.

lammel
lammel approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

First just ensure a never used NotFoundHandler will really never be used.
Second is just unneeded return.

@sivchari
Copy link
Contributor Author

Sorry to response late. Ah, what do I do ?

@lammel
Copy link
Contributor

lammel commented Jan 24, 2022

Sorry to response late. Ah, what do I do ?

Nothing, change is simple enough. No changes to behaviour or tests ;-)

@lammel lammel merged commit f3865f9 into labstack:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lammel lammel lammel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sivchari @lammel