Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade go directive in go.mod to 1.17 #2049

Merged
merged 1 commit into from Jan 24, 2022
Merged

build: upgrade go directive in go.mod to 1.17 #2049

merged 1 commit into from Jan 24, 2022

Conversation

Juneezee
Copy link
Contributor

This PR upgrades the go directive in go.mod file by running go mod tidy -go=1.17 to enable module graph pruning and lazy module loading.

Note 1: This does not prevent users with earlier Go versions from successfully building packages from this module.

Note 2: The additional require directive is used to record indirect dependencies for Go 1.17 or higher, see https://go.dev/ref/mod#go-mod-file-go.

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #2049 (63e2b32) into master (aada6f9) will increase coverage by 0.20%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2049      +/-   ##
==========================================
+ Coverage   91.57%   91.77%   +0.20%     
==========================================
  Files          33       36       +3     
  Lines        2921     2968      +47     
==========================================
+ Hits         2675     2724      +49     
+ Misses        157      156       -1     
+ Partials       89       88       -1     
Impacted Files Coverage Δ
context.go 88.04% <ø> (+1.10%) ⬆️
group.go 100.00% <ø> (ø)
router.go 96.50% <ø> (-0.02%) ⬇️
context_fs_go1.16.go 80.00% <80.00%> (ø)
echo_fs_go1.16.go 95.83% <95.83%> (ø)
bind.go 89.47% <100.00%> (+0.06%) ⬆️
echo.go 95.14% <100.00%> (+0.93%) ⬆️
group_fs_go1.16.go 100.00% <100.00%> (ø)
middleware/recover.go 84.21% <100.00%> (+2.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feaa6ed...63e2b32. Read the comment docs.

@lammel
Copy link
Contributor

lammel commented Jan 23, 2022

Looks good to me. Go is moving forward to allowing reproducable builds with Go 1.18. So moving in that direction seems fine to me.
Thoughs @aldas @pafuent ?

Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was little bit vary of this because of older Go versions. This is due my ignorance of that directive. But we already have go 1.15 and still support 1.14 and nobody is complaining - so it is probably ok.

This commit enables support for module graph pruning and lazy module
loading for projects that are at Go 1.17 or higher.

Reference: https://go.dev/ref/mod#go-mod-file-go
Reference: https://go.dev/ref/mod#graph-pruning
Reference: https://go.dev/ref/mod#lazy-loading
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants