Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LOCK/UNLOCK verbs. #1610

Closed
the-maldridge opened this issue Jul 14, 2020 · 3 comments
Closed

Support LOCK/UNLOCK verbs. #1610

the-maldridge opened this issue Jul 14, 2020 · 3 comments

Comments

@the-maldridge
Copy link

I'd like to add support for the LOCK/UNLOCK HTTP verbs as I am developing an application that expects to consume these verbs before synchronizing a conflicting operation on shared state. Prior to adding this support to Echo I'd like to gain some agreement that a patch will be accepted for this functionality as there is not an http.MethodLock constant in the net/http library. I can either add this method in the constants in echo.go or I can add it inline.

@lammel
Copy link
Contributor

lammel commented Jul 20, 2020

It would only make sense to support WebDAV as a whole as these methods are defined in RFC 4918: HTTP Extensions for Web Distributed Authoring and Versioning (WebDAV)

This is more or less a duplicate of #1459 which requested WebDAV support, but went stale.

A PR would definitely be welcome and considered for full WebDAV support. Go core libs shall be reused as much as possible though and dependencies must be kept to a minimum to avoid bloat.

@stale
Copy link

stale bot commented Nov 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 7, 2020
yixy added a commit to yixy/echo that referenced this issue May 4, 2022
Signed-off-by: yixy <youzhilane01@gmail.com>
@aldas
Copy link
Contributor

aldas commented Aug 11, 2022

closing, from v4.8.0 this is possible. See #2237

@aldas aldas closed this as completed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants