Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make ServiceMonitor scrape_interval and scrape_timeout optional in helm chart #10227

Open
2 tasks done
bruksnys opened this issue May 13, 2024 · 1 comment
Open
2 tasks done
Labels
enhancement New feature or request helm Issues dealing with the Helm chart

Comments

@bruksnys
Copy link

Problem Statement

We prefer to use global values for all of our ServiceMonitors since it greatly simplifies the maintenance and allows us to have consistent scrape intervals that play well with various other metrics in our observability stack and return consistent results when comparing them using promql rate() function.

Solution Description

By modifying ServiceMonitor resource templates to allow for empty values - global scrape_interval and scrape_timeout values would be respected. Then, if an override is desired, operator could simply specify these values.

Alternatives

No response

Additional Context

At the moment scrape_interval and scrape_timeout values for the ServiceMonitor resource are set by default to 30s and 25s respectively here:
https://github.com/kyverno/kyverno/blob/main/charts/kyverno/values.yaml#L1220-L1223

If unspecified - these values would default to globals. Helm templates currently do not support having these values as undefined and thus always set a scrape_timeout which might be different from the global defaults.

Slack discussion

No response

Research

  • I have read and followed the documentation AND the troubleshooting guide.
  • I have searched other issues in this repository and mine is not recorded.
@bruksnys bruksnys added enhancement New feature or request triage Default label assigned to all new issues indicating label curation is needed to fully organize. labels May 13, 2024
Copy link

welcome bot commented May 13, 2024

Thanks for opening your first issue here! Be sure to follow the issue template!

@MariamFahmy98 MariamFahmy98 added helm Issues dealing with the Helm chart and removed triage Default label assigned to all new issues indicating label curation is needed to fully organize. labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm Issues dealing with the Helm chart
Projects
None yet
Development

No branches or pull requests

2 participants