-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
truncate event messages to 1024 chars #10255
Merged
realshuting
merged 3 commits into
kyverno:main
from
JimBugwadia:truncate_event_messages
May 20, 2024
Merged
truncate event messages to 1024 chars #10255
realshuting
merged 3 commits into
kyverno:main
from
JimBugwadia:truncate_event_messages
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10255 +/- ##
==========================================
+ Coverage 10.17% 10.18% +0.01%
==========================================
Files 1030 1030
Lines 91836 91839 +3
==========================================
+ Hits 9343 9356 +13
+ Misses 81471 81460 -11
- Partials 1022 1023 +1 ☔ View full report in Codecov by Sentry. |
MariamFahmy98
approved these changes
May 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
realshuting
approved these changes
May 20, 2024
/cherry-pick release-1.12 |
realshuting
added
the
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
label
May 20, 2024
realshuting
pushed a commit
that referenced
this pull request
May 20, 2024
anushkamittal2001
pushed a commit
to nirmata/kyverno
that referenced
this pull request
May 24, 2024
Co-authored-by: Jim Bugwadia <jim@nirmata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
cherry-pick-required
milestone 1.12.2
milestone 1.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Truncate event message lengths to 1024 characters
Related issue
Fixes #10210
Milestone of this PR
1.12.2
Documentation (required for features)
My PR contains new or altered behavior to Kyverno.
What type of PR is this
/kind bug
Proposed Changes
Truncate event message lengths to 1024 characters
Proof Manifests
See unit tests
Checklist
Further Comments