Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncate event messages to 1024 chars #10255

Merged
merged 3 commits into from
May 20, 2024

Conversation

JimBugwadia
Copy link
Member

@JimBugwadia JimBugwadia commented May 18, 2024

Explanation

Truncate event message lengths to 1024 characters

Related issue

Fixes #10210

Milestone of this PR

1.12.2

Documentation (required for features)

My PR contains new or altered behavior to Kyverno.

What type of PR is this

/kind bug

Proposed Changes

Truncate event message lengths to 1024 characters

Proof Manifests

See unit tests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.

Further Comments

Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.18%. Comparing base (d580ae0) to head (915bde9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10255      +/-   ##
==========================================
+ Coverage   10.17%   10.18%   +0.01%     
==========================================
  Files        1030     1030              
  Lines       91836    91839       +3     
==========================================
+ Hits         9343     9356      +13     
+ Misses      81471    81460      -11     
- Partials     1022     1023       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MariamFahmy98 MariamFahmy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realshuting
Copy link
Member

/cherry-pick release-1.12

@realshuting realshuting merged commit 46e5d81 into kyverno:main May 20, 2024
249 of 250 checks passed
@realshuting realshuting added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label May 20, 2024
realshuting pushed a commit that referenced this pull request May 20, 2024
Co-authored-by: Jim Bugwadia <jim@nirmata.com>
anushkamittal2001 pushed a commit to nirmata/kyverno that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required milestone 1.12.2 milestone 1.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Reports are not created for validate.podSecurity rules
3 participants