fix: deepcopy patched resource in foreach mutate #10252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
vishal-chdhry
requested review from
chipzoller,
eddycharly,
realshuting,
MariamFahmy98,
KhaledEmaraDev and
MarcelMue
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10252 +/- ##
=======================================
Coverage 10.16% 10.17%
=======================================
Files 1030 1030
Lines 91833 91836 +3
=======================================
+ Hits 9338 9343 +5
+ Misses 81473 81471 -2
Partials 1022 1022 ☔ View full report in Codecov by Sentry. |
vishal-chdhry
changed the title
JimBugwadia
added
the
release-critical
realshuting
approved these changes
May 20, 2024
|
/cherry-pick release-1.12 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
May 20, 2024
* fix: deepcopy patched resource to avoid indirect reversal of its elements Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: copy elements while reversing Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: copy resources inside foreach Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * add test Signed-off-by: Jim Bugwadia <jim@nirmata.com> * add test Signed-off-by: Jim Bugwadia <jim@nirmata.com> --------- Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> Signed-off-by: Jim Bugwadia <jim@nirmata.com> Co-authored-by: Jim Bugwadia <jim@nirmata.com>
realshuting
added
the
cherry-pick-completed
realshuting
pushed a commit
that referenced
this pull request
May 20, 2024
* fix: deepcopy patched resource to avoid indirect reversal of its elements * fix: copy elements while reversing * fix: copy resources inside foreach * add test * add test --------- Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> Signed-off-by: Jim Bugwadia <jim@nirmata.com> Co-authored-by: Vishal Choudhary <vishal.choudhary@nirmata.com> Co-authored-by: Jim Bugwadia <jim@nirmata.com>
anushkamittal2001
pushed a commit
to nirmata/kyverno
that referenced
this pull request
May 24, 2024
…erno#10258) * fix: deepcopy patched resource to avoid indirect reversal of its elements * fix: copy elements while reversing * fix: copy resources inside foreach * add test * add test --------- Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> Signed-off-by: Jim Bugwadia <jim@nirmata.com> Co-authored-by: Vishal Choudhary <vishal.choudhary@nirmata.com> Co-authored-by: Jim Bugwadia <jim@nirmata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
After commit 46f02a8, when the order is set to
Descendingin foreach mutate, the order of items in the trigger resource also gets reverted, causing the wrong item to get patched.This PR:
Related issue
Closes #10224
Closes #10199
Milestone of this PR
Documentation (required for features)
My PR contains new or altered behavior to Kyverno.
What type of PR is this
Proposed Changes
Proof Manifests
Checklist
Further Comments