Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support exclude block in generating VAPs #10215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support exclude block in generating VAPs #10215

wants to merge 1 commit into from

Conversation

MariamFahmy98
Copy link
Collaborator

Explanation

This PR supports generating ValidatingAdmissionPolicies from policies that specifies the exclude block.

Related issue

Closes #10196

Milestone of this PR

/milestone 1.13.0

Documentation (required for features)

My PR contains new or altered behavior to Kyverno.

What type of PR is this

/kind feature

Proposed Changes

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.

Further Comments

@MariamFahmy98
feat: support exclude block in generating VAPs
486da4b 
Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
@MariamFahmy98 MariamFahmy98 added this to the Kyverno Release 1.13.0 milestone May 9, 2024
@codecov Codecov
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 75 lines in your changes are missing coverage. Please review.

Project coverage is 10.15%. Comparing base (6fec524) to head (486da4b).

Files Patch % Lines
pkg/validatingadmissionpolicy/builder.go 0.00% 47 Missing ⚠️
...validatingadmissionpolicy/kyvernopolicy_checker.go 51.72% 14 Missing and 14 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10215   +/-   ##
=======================================
  Coverage   10.15%   10.15%           
=======================================
  Files        1030     1030           
  Lines       91812    91862   +50     
=======================================
+ Hits         9319     9333   +14     
- Misses      81473    81501   +28     
- Partials     1020     1028    +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MariamFahmy98 MariamFahmy98 mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipzoller chipzoller Awaiting requested review from chipzoller chipzoller is a code owner

@eddycharly eddycharly Awaiting requested review from eddycharly eddycharly is a code owner

@realshuting realshuting Awaiting requested review from realshuting realshuting is a code owner

@KhaledEmaraDev KhaledEmaraDev Awaiting requested review from KhaledEmaraDev KhaledEmaraDev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
milestone 1.13.0
Projects
None yet
Milestone
Kyverno Release 1.13.0
Development

Successfully merging this pull request may close these issues.

[Feature] Support generating VAPs from policies that define exclude block
1 participant
@MariamFahmy98