Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sqlite) Adds support for column aliases and function arguments #1455

Merged
merged 10 commits into from Feb 25, 2022
Merged

feat(sqlite) Adds support for column aliases and function arguments #1455

merged 10 commits into from Feb 25, 2022

Conversation

PadraigK
Copy link
Contributor

PadraigK
PadraigK commented Feb 24, 2022
View reviewed changes
internal/endtoend/testdata/func_match_types/sqlite/go/query.sql.go
type AuthorPagesRow struct {
Author string
NumBooks int64
TotalPages float64
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an int64 once #1450 is fixed

@PadraigK PadraigK marked this pull request as ready for review February 24, 2022 00:04
@kyleconroy kyleconroy merged commit 5842e84 into sqlc-dev:main Feb 25, 2022
@StevenACoffman StevenACoffman mentioned this pull request Apr 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PadraigK @kyleconroy