Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for delete statements #1447

Merged
merged 26 commits into from Feb 19, 2022
Merged

Add support for delete statements #1447

merged 26 commits into from Feb 19, 2022

Conversation

PadraigK
Copy link
Contributor

  • Adds support for delete statements
  • Regenerated parser to label various expression types
  • Fixes feedback from previous PR

PadraigK and others added 26 commits February 16, 2022 17:14
@PadraigK
Improve test to illustrate correctness
1c8cdfb
@PadraigK
Add rename table test
fd5ab20
@PadraigK
Rename column tests
22055d1
@PadraigK
run regen
40fdea3
@PadraigK
Test syntax without COLUMN keyword
45701ee
@PadraigK
Add column SQLite
0ff8188
@PadraigK
Add a more complex create table
66d0d75
@PadraigK
Check not null too
f44d196
@PadraigK
Add create trigger
41357d4
@PadraigK
adds test for drop table
382e1f3
@PadraigK
Fix drop table logic
9d8a8bf
@PadraigK
Add drop table if exists test
6a70713
@PadraigK
fix early return
877f02e
@PadraigK
add failing test
efc2a3f
@PadraigK
wip
7448dcf
@PadraigK
move thing back
aa30261
@PadraigK
Merge branch 'main' into padraig/delete-stmt
54a8daa 
# Conflicts:
#	internal/engine/sqlite/convert.go
@PadraigK
undo
a331c4d
@PadraigK
Label various expr types
c2a9218
@PadraigK
Regen
34a3955
@PadraigK
better names
047c3a2
@PadraigK
fix impacts of parse regen
ff91ab5
@PadraigK
Support for 1 param where comparisons
275aeb0
@PadraigK
Add handling for more expression types
4c10ec1
@PadraigK
Feedback from previous PR
b38000c
@PadraigK
remove old commented code
8a5185d
@PadraigK PadraigK marked this pull request as ready for review February 19, 2022 00:51
kyleconroy
kyleconroy approved these changes Feb 19, 2022
View reviewed changes
Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had no idea you could add labels using comments

@kyleconroy kyleconroy merged commit fc7bf6d into sqlc-dev:main Feb 19, 2022
@PadraigK
Copy link
Contributor Author

Had no idea you could add labels using comments

Yeah! I was pretty stuck with converting more complex expressions to the AST until I discovered this:
https://github.com/antlr/antlr4/blob/master/doc/parser-rules.md#alternative-labels

@StevenACoffman StevenACoffman mentioned this pull request Apr 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleconroy kyleconroy kyleconroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PadraigK @kyleconroy