Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added postgres CALL support #1495

Merged
merged 3 commits into from Mar 25, 2022
Merged

Conversation

terrycain
Copy link
Contributor

Not sure if I've gone about this the right way but it seems to generate ok.

Let me know if there's anything else that needs to be done for this.

Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the changes to sqlc/named and sqlc/rewrite are needed once we define the FuncCall field value as a pointer.

internal/sql/ast/call_stmt.go Outdated Show resolved Hide resolved
internal/sql/ast/call_stmt.go Show resolved Hide resolved
internal/sql/astutils/walk.go Outdated Show resolved Hide resolved
@terrycain
Copy link
Contributor Author

@kyleconroy I think I've resolved all the issues :)

@kyleconroy kyleconroy merged commit 582ba6e into sqlc-dev:main Mar 25, 2022
@terrycain terrycain deleted the add_call_support branch March 25, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants