Fixes error with international URLs that have more than 2 hyphens #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 42ea2fd.
# Conflicts: # validators/url.py
|
@kvesteri Could you please give an update about pending pull requests? Are help and new contributions accepted? |
kvesteri
approved these changes
Jun 5, 2022
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 19, 2022
https://build.opensuse.org/request/show/982861 by user mia + dimstar_suse - Update to 0.20.0 * Add ipv4 digit lenghts validation (gh#python-validators/validators#191) * Fix error with international URLs that have more than 2 hyphens (gh#python-validators/validators#184) Changes in 0.19.0: * Improve IPv6 validation (gh#python-validators/validators#201 gh#python-validators/validators#107) * Drop support for Python 3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a URL like
http://xn----gtbybh.xn--p1ai/1/asdfwould fail validation since the regex only allowed for 2 hyphens after the "xn". However, certain encodings allow for up to 4 of them. This PR fixes that issue.