Feature/pg composite mixed case support #584
Merged
+78
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes were made to this PR to instead utilize SQLAlchemy's identifier quoting rules/options. |
|
Well, I had claimed that all tests had passed on my system. The automated test results made me take another look and I obviously found the linting error (newline) I missed in I do run into other sqla14 errors on my end as well, but those are not caused by my additions. Another issue will have to solve those errors. When there are errors in the test results prior to making code changes, it's easy to miss errors that are added. Such is what happened when I added the linting error which I overlooked. |
bamartin125
force-pushed
the
feature/pg-composite-mixed-case-support
branch
from
66d26e4 to
fee22e1
Compare
|
I've just squashed my commits and rebased with the latest sqlalchemy-utils master commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #583