Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explain and explain_analyze #408

Merged
merged 1 commit into from Dec 8, 2019

Conversation

kvesteri
Copy link
Owner

@kvesteri kvesteri commented Dec 8, 2019

No description provided.

@kvesteri kvesteri force-pushed the feature/remove-explain-and-explain-analyze branch from 02e33c3 to 02e9e20 Compare December 8, 2019 17:18
@kvesteri kvesteri force-pushed the feature/remove-explain-and-explain-analyze branch from 02e9e20 to 87d9ad8 Compare December 8, 2019 17:27
@kvesteri kvesteri merged commit 627e2a3 into master Dec 8, 2019
@kvesteri kvesteri deleted the feature/remove-explain-and-explain-analyze branch December 8, 2019 17:37
@anthony-chaudhary
Copy link

Hey, maybe this could be removed from docs?
https://sqlalchemy-utils.readthedocs.io/en/stable/database_helpers.html#analyze

image

File "<stdin>", line 1, in <module>
AttributeError: module 'sqlalchemy_utils.functions' has no attribute 'analyze'

(makes sense seeing this commit)

@lpsinger
Copy link
Contributor

Why was this removed?

@kvesteri
Copy link
Owner Author

SQLAlchemy internals (which this function relied on) changed a lot and thus the function stopped working. It was never a good idea to use those internals in the first place.

@kvesteri
Copy link
Owner Author

The reference is now removed from docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants