Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MSSQL when creating/dropping db #337

Merged
merged 4 commits into from Nov 19, 2018
Merged

Add support for MSSQL when creating/dropping db #337

merged 4 commits into from Nov 19, 2018

Conversation

jomasti
Copy link
Contributor

@jomasti jomasti commented Aug 3, 2018

No description provided.

@jomasti
Copy link
Contributor Author

jomasti commented Aug 3, 2018

I tested this locally using a SQL Server instance in Docker. I guess the same would need to be done in Travis to support running tests against SQL Server. Or maybe setting up AppVeyor and only running SQL Server tests there.

@deterralba
Copy link

I wanted to ask if we the support for sql server would be welcome for the create/drop operation, I am glad to see it's an ongoing work!

The value of engine.url.database is None when we use exact pyobdc strings (see http://docs.sqlalchemy.org/en/latest/dialects/mssql.html#pass-through-exact-pyodbc-string), hence the database creation fails.
Should this be patched here or should I create an issue the sqlalchemy repo?

@kvesteri
Copy link
Owner

Thanks for the PR. In order for this to get merged the travis CI must be configured to support MSSQL as well.

@jomasti
Copy link
Contributor Author

jomasti commented Nov 18, 2018

@kvesteri Travis is set up with SQL Server now.

@kvesteri kvesteri merged commit c5672cf into kvesteri:master Nov 19, 2018
@kvesteri
Copy link
Owner

Thanks for the PR! 🚋

@jomasti jomasti deleted the feature/support-msql-create-drop branch December 1, 2018 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants