fix(get_locale): set default locale to 'en' without Flask-Babel #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aveuiller
force-pushed
the
332_define_default_get_locale
branch
2 times, most recently
from
634e26f
to
a56c7b1
Compare
kdeldycke
reviewed
Jul 17, 2018
sqlalchemy_utils/i18n.py
Outdated
| except ImportError: | ||
| def get_locale(): return babel.Locale('en') | ||
| except AttributeError: | ||
| # As babel is optional, we may raise an AttributeError accessing it | ||
| def get_locale(): | ||
| raise ImproperlyConfigured( | ||
| 'Could not load get_locale function from Flask-Babel. Either ' |
There was a problem hiding this comment.
Now that Flask-Babel is no longer required I guess you can remove mention of it in the error message.
added 2 commits
July 17, 2018 10:27
An exception is still raised if babel is not installed at all.
aveuiller
force-pushed
the
332_define_default_get_locale
branch
from
a56c7b1
to
c863854
Compare
dahlia
approved these changes
Aug 21, 2018
|
Any news on that one? :) |
|
Thanks for the PR! 🚋 |
|
Thanks @kvesteri for the merge and release! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #332