Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #245: create column aliases in the version table #246

Merged
merged 1 commit into from May 24, 2020
Merged

Fix #245: create column aliases in the version table #246

merged 1 commit into from May 24, 2020

Conversation

killthekitten
Copy link
Contributor

This is more of a proof of concept, as I'm not sure about several things:

  1. Is ModelBuilder a good place to create "aliases"?
  2. What would be a correct SQLAlchemy terminology for this?
  3. Property names different from column names are not respected in inherited classes #245 is an issue I had with STI, but it might not be limited just to that. What would be a better place for putting the tests?

@killthekitten killthekitten mentioned this pull request May 6, 2020
Open
@killthekitten killthekitten force-pushed the fix-245-create-column-aliases branch from 5d6b846 to f063c9d Compare May 6, 2020 20:03
@killthekitten killthekitten force-pushed the fix-245-create-column-aliases branch from f063c9d to f2ee5b6 Compare May 6, 2020 21:37
@killthekitten
Copy link
Contributor Author

@kvesteri did you have a chance to take a look at this?

@kvesteri kvesteri merged commit b5c732f into kvesteri:master May 24, 2020
@kvesteri
Copy link
Owner

Thanks for the PR! The terminology and changes looked good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@killthekitten @kvesteri