Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test workflow tweaks and other random improvements #21

Merged
merged 10 commits into from Jun 7, 2022
Merged

Test workflow tweaks and other random improvements #21

merged 10 commits into from Jun 7, 2022

Conversation

magnetikonline
Copy link
Contributor

@magnetikonline magnetikonline commented Jun 7, 2022

A bit of a grab bag here:

  • Moved GitHub workflow from main.yml -> test.yml
  • Renamed workflow to Test
  • Workflow (tests) now run on every PR, every PR change and merge to main
  • Workflow uses explicit Golang version (1.17)
  • Removed -cover from go test in workflow (no need, we don't use it)
  • Bumped to actions/checkout@v3
  • Updated README.md test badge
  • Rando README.md cleanups - most around the Golang code examples.
  • Bump project to Golang 1.17
  • go mod vendor
  • Removed a hanging coverage.out file (don't think this should have been committed).

@magnetikonline
Copy link
Contributor Author

@kunwardeep you'll have to approve the workflow change - also the branch protection rule will need an update/change.

@kunwardeep
Copy link
Owner

@kunwardeep you'll have to approve the workflow change - also the branch protection rule will need an update/change.

Yess!!
Screen Shot 2022-06-07 at 3 56 39 pm

@magnetikonline
Copy link
Contributor Author

Screen Shot 2022-06-07 at 4 01 38 pm

Just need to change the dependent workflow in the branch configuration under settings for the repo @kunwardeep.

@kunwardeep kunwardeep merged commit c61ab88 into kunwardeep:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants