Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to ignore missing calls (off by default) #19

Merged
merged 5 commits into from Jun 7, 2022
Merged

Add flag to ignore missing calls (off by default) #19

merged 5 commits into from Jun 7, 2022

Conversation

turbolent
Copy link
Contributor

@turbolent turbolent commented Jun 7, 2022 •
edited

Closes #16

Add a new flag -i which ignores missing calls to t.Parallel and only reports incorrect uses of it.

kunwardeep
kunwardeep reviewed Jun 7, 2022
View reviewed changes
Copy link
Owner

@kunwardeep kunwardeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the quick PR. Would you be able to add some tests for the flag ignoreMissing

@kunwardeep
Copy link
Owner

And I would highly appreciate it if we could update the readme.

@turbolent
Copy link
Contributor Author

@kunwardeep Good points, added both

@kunwardeep kunwardeep merged commit 5bd86f2 into kunwardeep:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunwardeep kunwardeep kunwardeep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mode to only report invalid uses of t.Parallel, but not missing ones
2 participants
@turbolent @kunwardeep