Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supplemnt a mermaid graph for multi-zone #1771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

supplemnt a mermaid graph for multi-zone #1771

wants to merge 1 commit into from

Conversation

Icarus9913
Copy link
Contributor

close #1767

Did you sign your commit? Instructions - yes

Have you read Contributing guidelines? -yes

@Icarus9913 Icarus9913 requested a review from a team as a code owner April 24, 2024 07:03
@Icarus9913 Icarus9913 requested review from michaelbeaumont and Automaat and removed request for a team April 24, 2024 07:03
@netlify Netlify
Copy link

netlify bot commented Apr 24, 2024 •
edited

✅ Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 34dbcf0
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/6628d4e583417100080547a3
😎 Deploy Preview https://deploy-preview-1771--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🔴 down 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

bartsmykla
bartsmykla requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work: https://deploy-preview-1771--kuma.netlify.app/docs/2.7.x/production/deployment/multi-zone/#how-it-works

@Icarus9913
supplemnt a mermaid graph for multi-zone
34dbcf0 
Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla requested changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont michaelbeaumont is a code owner automatically assigned from kumahq/kuma-website-maintainers

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-website-maintainers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The multi-zone section lacks of a graph
2 participants
@Icarus9913 @bartsmykla