Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use transformer config in config:init instead of globals #3829

Merged
merged 1 commit into from Sep 23, 2022
Merged

fix: use transformer config in config:init instead of globals #3829

merged 1 commit into from Sep 23, 2022

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Sep 23, 2022

Test plan

Updated tests
Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3111008341

  • 29 of 37 (78.38%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 96.168%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/cli/config/init.ts 28 36 77.78%
Totals Coverage Status
Change from base Build 3110931903: 0.1%
Covered Lines: 4006
Relevant Lines: 4111
💛 - Coveralls

Repository owner deleted a comment from coveralls Sep 23, 2022
@ahnpnl ahnpnl merged commit 214cb8c into kulshekhar:main Sep 23, 2022
@ahnpnl ahnpnl deleted the fix/init-config branch September 23, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahnpnl @coveralls @kulshekhar