Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(config): bring back possibility to mock logging in test #2053

Merged
merged 1 commit into from
Oct 22, 2020
Merged

refactor(config): bring back possibility to mock logging in test #2053

merged 1 commit into from
Oct 22, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Oct 22, 2020

Summary

The PR #2050 accidentally removed the possibility to mock logging for testing. This PR is to bring back that feature.

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

coveralls commented Oct 22, 2020 •
edited

Pull Request Test Coverage Report for Build 6265

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.692%
Totals Coverage Status
Change from base Build 6263: 0.01%
Covered Lines: 1029
Relevant Lines: 1058
💛 - Coveralls

@ahnpnl ahnpnl merged commit a0e5639 into kulshekhar:master Oct 22, 2020
@ahnpnl ahnpnl deleted the mock-logger branch October 22, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahnpnl @coveralls @kulshekhar