refactor(config): refactor ConfigSet class
#2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert most of getter to private fields - Optimize logic of mapping user config to internal config - Expose a few getters as public apis
Pull Request Test Coverage Report for Build 6255
💛 - Coveralls |
kulshekhar
approved these changes
Oct 21, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TsJestConfig$diagnosticstoTsJestDiagnosticsCfgCachedConfigSetto cache transformerConfig string instead of object typeTest plan
Readjusted some unit tests, most of unit tests are the same. Green CI
Does this PR introduce a breaking change?
Other information
N.A.