You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The patches folder does not get ignored. Changing "patches/**" to "./patches/**" does not work, either.
However, changing "patches/**" to "**/patches/**" ignores the root patches folder, but carries the risk of ignoring a subfolder with the same name that shouldn't be ignored.
An absolute path works, but is non-portable: /home/username/repos/reponame/patches
To Reproduce
Steps to reproduce the behavior:
Have code in a subfolder that has a . prefix
manually add it to the ignore section of your config, using the path from project root
run jscpd
folder from step 1 is not ignored
Expected behavior
A path that is in the ignore should follow filesystem rules.
/foo/** should ignore anything insides the system root "foo" folder.
foo/** and ./foo/** should ignore anything inside the "foo" folder at the project root
Desktop (please complete the following information):
OS: WSL2
OS Version: Ubuntu 22.04.2 LTS
NodeJS Version: 18.16.1
jscpd version: 3.5.10
The text was updated successfully, but these errors were encountered:
FFdhorkin
changed the title
"ignore" does not work with paths that don't start with a wildcard glob
"ignore" does not work with relative paths that don't start with a wildcard glob
Oct 21, 2023
Describe the bug
jscpd does not ignore paths that start with a relative path (as opposed to wildcard glob). Absolute paths work fine.
For example, with the following
.jscpd.json
:The patches folder does not get ignored. Changing
"patches/**"
to"./patches/**"
does not work, either.However, changing
"patches/**"
to"**/patches/**"
ignores the root patches folder, but carries the risk of ignoring a subfolder with the same name that shouldn't be ignored.An absolute path works, but is non-portable:
/home/username/repos/reponame/patches
To Reproduce
Steps to reproduce the behavior:
.
prefixignore
section of your config, using the path from project rootExpected behavior
A path that is in the ignore should follow filesystem rules.
/foo/**
should ignore anything insides the system root "foo" folder.foo/**
and./foo/**
should ignore anything inside the "foo" folder at the project rootDesktop (please complete the following information):
The text was updated successfully, but these errors were encountered: