Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2021-0013: Soundness issues in raw-cpuid #68

Closed
github-actions bot opened this issue Jun 8, 2021 · 1 comment · Fixed by #69
Closed

RUSTSEC-2021-0013: Soundness issues in raw-cpuid #68

github-actions bot opened this issue Jun 8, 2021 · 1 comment · Fixed by #69
Projects

Comments

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Soundness issues in raw-cpuid

Details
Package raw-cpuid
Version 7.0.4
URL rustsec/advisory-db#614
Date 2021-01-20
Patched versions >=9.0.0

Undefined behavior in as_string() methods

VendorInfo::as_string(), SoCVendorBrand::as_string(),
and ExtendedFunctionInfo::processor_brand_string() construct byte slices
using std::slice::from_raw_parts(), with data coming from
#[repr(Rust)] structs. This is always undefined behavior.

See gz/rust-cpuid#40.

This flaw has been fixed in v9.0.0, by making the relevant structs
#[repr(C)].

native_cpuid::cpuid_count() is unsound

native_cpuid::cpuid_count() exposes the unsafe __cpuid_count() intrinsic
from core::arch::x86 or core::arch::x86_64 as a safe function, and uses
it internally, without checking the
safety requirement:

> The CPU the program is currently running on supports the function being
> called.

CPUID is available in most, but not all, x86/x86_64 environments. The crate
compiles only on these architectures, so others are unaffected.

This issue is mitigated by the fact that affected programs are expected
to crash deterministically every time.

See gz/rust-cpuid#41.

The flaw has been fixed in v9.0.0, by intentionally breaking compilation
when targetting SGX or 32-bit x86 without SSE. This covers all affected CPUs.

See advisory page for additional details.

@ereslibre ereslibre self-assigned this Jun 8, 2021
@ereslibre ereslibre added this to In progress in Development Jun 8, 2021
ereslibre added a commit that referenced this issue Jun 8, 2021
@flavio flavio closed this as completed in #69 Jun 8, 2021
@ereslibre ereslibre reopened this Jun 8, 2021
@ereslibre ereslibre moved this from In progress to TODO in Development Jun 8, 2021
@ereslibre ereslibre removed their assignment Jun 8, 2021
@flavio
Copy link
Member

flavio commented Jun 8, 2021

This is now fixed

@flavio flavio closed this as completed Jun 8, 2021
@flavio flavio moved this from TODO to Done in Development Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development
Done (weekly)
Development

Successfully merging a pull request may close this issue.

2 participants