Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain-qualified finalizer names #728

Open
jvanz opened this issue Apr 19, 2024 · 3 comments
Open

Domain-qualified finalizer names #728

jvanz opened this issue Apr 19, 2024 · 3 comments
Milestone

Comments

@jvanz
Copy link
Member

jvanz commented Apr 19, 2024

When ran the integration tests we see this warning messages:

  2024-04-19T14:43:33-03:00     INFO    KubeAPIWarningLogger    metadata.finalizers: "integration-tests-safety-net-finalizer": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers
  2024-04-19T14:43:33-03:00     INFO    KubeAPIWarningLogger    metadata.finalizers: "kubewarden": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers

We should address that to follow the best practices.

Acceptance criteria

  • Use domain-qualified finalizer names
  • Ensure that tests are passing
  • Ensure the upgrade path is passing
@flavio
Copy link
Member

flavio commented Apr 22, 2024

I would add this one to 1.13, given we're doing quite some cleanups inside of the controller. At least everything will be tested at the same time.

What do the other @kubewarden/kubewarden-developers think about that?

@jvanz
Copy link
Member Author

jvanz commented Apr 22, 2024

I would add this one to 1.13, given we're doing quite some cleanups inside of the controller. At least everything will be tested at the same time.

What do the other @kubewarden/kubewarden-developers think about that?

Fine by me

@viccuad
Copy link
Member

viccuad commented Apr 25, 2024

Fine by me too. Added to milestone.

@viccuad viccuad added this to the 1.13 milestone Apr 25, 2024
@jvanz jvanz modified the milestones: 1.13, 1.14 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants