Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: New Policy to enforce a set Liveness and/or Readiness Probe #669

Open
TechDufus opened this issue Mar 4, 2024 · 2 comments

Comments

@TechDufus
Copy link

TechDufus commented Mar 4, 2024

Is your feature request related to a problem?

No, Just a suggestion for a new Policy.

Solution you'd like

It would be useful for us for a policy that enforces a non-empty Liveness and/or Readiness probe for each pod. In an effort to enforce 'best practices', Enforcing this for our devs would force health endpoints and better health reporting from engineers monitoring the environments.

Possibly a minimal config like this?

liveness:
  enforce: true
readiness:
  enforce: true

I could see this going as far as to enforce periodSeconds with a default minimum or limit. "For better response times, we limit Liveness probes to 30s", is an example use case / purpose for this.

Alternatives you've considered

No response

Anything else?

No response

@viccuad
Copy link
Member

viccuad commented Mar 11, 2024

I am aware of a community rust policy that implements this: https://github.com/nlamirault/probes-policy

We contacted the author in the past, the policy seems ready, and the steps for publishing it into artifacthub.io seem almost done. From the looks of it, the policy is missing an artifacthub id in artifacthub-repo.yml that can be provided by the author when signed into artifacthub.io.

Another option is to provide a fork maintained by the Kubewarden team.

@flavio
Copy link
Member

flavio commented Mar 11, 2024

Another option is to provide a fork maintained by the Kubewarden team.

I think we should go that way given the maintainer doesn't seem to be actively maintaining it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants