Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reach close to 70% code coverage in the pkg package #663

Open
1 task
jvanz opened this issue Mar 1, 2024 · 1 comment
Open
1 task

Reach close to 70% code coverage in the pkg package #663

jvanz opened this issue Mar 1, 2024 · 1 comment

Comments

@jvanz
Copy link
Member

jvanz commented Mar 1, 2024

We have a goal to reach 70% of code coverage in the kubewarden controller repository. For that, we can improve the coverage of the pkg package. Considering the current metrics, this is the less covered package. However, I think that it's one of the most easy one to do. Most of the package is the types used in the controller. Therefore, to increase the coverage,simple unit tests verifying the methods should be enough.

I also think this can be done after the other packages. As the code does not have any major features, we may improve the coverage here by improving other packages coverage.

This is a spin off of #648

Acceptance criteria

  • Add unit tests for the types under the pkg to get close to 70% code coverage.
@jvanz jvanz changed the title Get to 70% code coverage in the pkg package Reach close to 70% code coverage in the pkg package Mar 1, 2024
@flavio
Copy link
Member

flavio commented Mar 1, 2024

Let's wait a bit before writing tests for the models. There are good chances portions of these files are going to be covered by the integration/new unit tests we will add.

Also, unless they have some special business logic done via methods, these files can also be ignored by the coverage report.

CC @fabriziosestito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants