Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create kubevirt-node-validate #11890

Open
victortoso opened this issue May 10, 2024 · 4 comments
Open

Create kubevirt-node-validate #11890

victortoso opened this issue May 10, 2024 · 4 comments

Comments

@victortoso
Copy link
Member

Is your feature request related to a problem? Please describe:

Sometimes it is hard to tell if KubeVirt can run in a given node or not. For instance, it is common to ask user to run virt-host-validate to check if something is missing on virtualization side but part of our stack might require new enough kernel or with some capabilities enabled.

Describe the solution you'd like:

We should have a tool that we could put this runtime requirements.

Additional context:

At the minimum, if a component crashes due lack of system's feature, we should be able to track it down by running this tool.
Perhaps it can be used to avoid scheduling VMs in unsupported nodes (I'm sure we already have code that does this kind of checks)

See: #11886

@fabiand
Copy link
Member

fabiand commented May 13, 2024 via email

@victortoso
Copy link
Member Author

Would this be a CLI tool? Or an addition to virtctl?

We would need to run it on the node, similar to virt-host-validate but with specific and important checks to KubeVirt to validate that node has runtime features we require such as /proc/sys/net/ipv4/ip_unprivileged_port_star mentioned in #11886.

Not sure how many checks we would need, but it feels right to have a place we could add KubeVirt specific node requirements.

How would you envision it to work?

At first, just a CLI tool. Could perhaps be integrated with virt-handler to validate further the node.

@alicefr
Copy link
Member

alicefr commented May 14, 2024

I'm a bit uncertain if we should really run "virt-host-validate" as part of kubevirt. Ideally, we should expose the various virtualization features in a way that kubernetes can understand and that they can be query also by regular users and ideally used by the scheduler.
Giving an example, kvm is present if we have the corresponding device plugin. Same for vhost-user.

@Muyan0828
Copy link

Can we return 1024 if /proc/sys/net/ipv4/ip_unprivileged_port_start does not exist? We won't be using passt-binding, so we can continue to use kubevirt on CentOS 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants