Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a unit test for VirtualMachineInstance api that test encoding/decoding #11629

Open
alaypatel07 opened this issue Apr 1, 2024 · 3 comments · May be fixed by #11856
Open

create a unit test for VirtualMachineInstance api that test encoding/decoding #11629

alaypatel07 opened this issue Apr 1, 2024 · 3 comments · May be fixed by #11856

Comments

@alaypatel07
Copy link
Contributor

Is your feature request related to a problem? Please describe:
There is a sig-api call every week where upcoming changes in kubevirt APIs are reviewed. In order to assist with the review process, there needs to be some kind of unit test that encode and decode the VMI objects to check for backward compatibility breakages.

Describe the solution you'd like:
There needs to be a unit test that decode from yaml to go structs and encodes from go structs to yaml objects. Both encoding and decoding should pass for each API change. This unit test will be very helpful in automating tests for api changes in kubevirt. References to such a unit test solution are here [1][2]

References:

  1. https://github.com/alaypatel07/kubevirt-api-fuzzer
  2. https://github.com/kubernetes/api/tree/master/testdata

Describe alternatives you've considered:
N/A

Additional context:
This feature will be part of kubevirt/community#221

@alaypatel07
Copy link
Contributor Author

@fabiand @xpivarc as per our discussions in kubecon. Choosing VMI api as one of the first api groups to add the testing since it is the building block of other abstractions.

@alaypatel07
Copy link
Contributor Author

/assign @Sreeja1725

@kubevirt-bot
Copy link
Contributor

@alaypatel07: GitHub didn't allow me to assign the following users: Sreeja1725.

Note that only kubevirt members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Sreeja1725

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sreeja1725 Sreeja1725 linked a pull request May 6, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants