ArgoCD health state of virt-launcher pod stays 'Progressing' forever

[jkleinlercher]

What happened:
when deploying a VirtualMachine like https://github.com/jkleinlercher/test9-repo/blob/master/helm/chart/templates/VirtualMachine.yaml via ArgoCD, the virt-launcer pod stays in status "progressing" forever.

What you expected to happen:
I want to see the pod in status "healthy"

How to reproduce it (as minimally and precisely as possible):
deploy a VirtualMachine with argocd and you will immediatly see the same behaviour

Additional context:

The reason is because the vm-launcher has set "restartPolicy: Never":

kubevirt/pkg/virt-controller/services/template.go

Line 583 in a565ade

RestartPolicy: k8sv1.RestartPolicyNever,

and according to argoproj/argo-cd#15317 and https://github.com/argoproj/gitops-engine/blob/187312fe86ed627b1cf4147c13dccf9ff331424b/pkg/health/health_pod.go#L30 when setting "restartPolicy: never", argocd doesn't set the pod state to healthy.

Does kubevirt need to set "restartPolicy: never" on the vm-launcher pod, or can we make this configurable?

Environment:

• KubeVirt version (use virtctl version): v1.2.0
• Kubernetes version (use kubectl version): 1.28
• VM or VMI specifications: N/A
• Cloud provider or hardware configuration: N/A
• OS (e.g. from /etc/os-release): N/A
• Kernel (e.g. uname -a): N/A
• Install tools: N/A
• Others: N/A

[aburdenthehand]

/cc @DMajrekar