Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM metrics should contains the vm and vmi's UUID #11795

Open
matthewei opened this issue Apr 25, 2024 · 6 comments
Open

VM metrics should contains the vm and vmi's UUID #11795

matthewei opened this issue Apr 25, 2024 · 6 comments
Assignees

Comments

@matthewei
Copy link
Contributor

Is your feature request related to a problem? Please describe:
we can create the same name vm in different namespace. we collect vm's metrics from different kubevirt cluster. So I want to add vm and vmi's UUID tags to distinguish them.

Describe the solution you'd like:
A clear and concise description of what you want to happen.

image

Describe alternatives you've considered:
A clear and concise description of any alternative solutions or features you've considered.

Additional context:
Add any other context or screenshots about the feature request here.

@matthewei
Copy link
Contributor Author

Please assign this PR to me if you think that is necessay for kubevirt project.

@xpivarc
Copy link
Member

xpivarc commented Apr 26, 2024

@machadovilaca thoughts?
I am wondering if this is best practice or the exporter per cluster should enrich the metrics

@matthewei
Copy link
Contributor Author

Even though, I think we should also need this UID just as kubernetes' pod. What do you think?

@machadovilaca
Copy link
Member

You could use the pair {namespace, name} to avoid conflicts of VMs names between different namespaces
But I see that, for example, kube-state-metrics also the uid in it's metrics.

It's fine for me to add it.

I would suggest waiting for #11601 to get merged. After it goes in, should be simple to add a new label from the VMI UID in

func (vmiReport *VirtualMachineInstanceReport) buildRuntimeLabels() {

@matthewei
Copy link
Contributor Author

matthewei commented May 7, 2024

yes, I want to work on it.
/assign

@matthewei
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants