Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix gitlab source repo options error #4270

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

yazhouio
Copy link
Member

@yazhouio yazhouio commented Apr 9, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: Fix gitlab source repo options error

Which issue(s) this PR fixes:

Fixes #kubesphere/ks-devops#1039

Special notes for reviewers:

Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2024
Copy link
Member Author

@yazhouio yazhouio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cherry-pick release-3.4

@yazhouio
Copy link
Member Author

yazhouio commented Apr 9, 2024

/retest

@ks-ci-bot ks-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2024
@yazhouio
Copy link
Member Author

yazhouio commented Apr 9, 2024

/retest

Signed-off-by: 古月 <git@yazhou.io>
Signed-off-by: 古月 <git@yazhou.io>
@donniean donniean added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 11, 2024
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: donniean, yazhouio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot merged commit 5cef966 into kubesphere:master Apr 11, 2024
6 checks passed
@yudong2015
Copy link

fixed: #4272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants