Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate legacy Slack tests to Cloud Slack #865

Closed
3 of 5 tasks
pkosiec opened this issue Nov 25, 2022 · 0 comments
Closed
3 of 5 tasks

Migrate legacy Slack tests to Cloud Slack #865

pkosiec opened this issue Nov 25, 2022 · 0 comments
Assignees
Labels
breaking Contains breaking change bug Something isn't working
Milestone

Comments

@pkosiec
Copy link
Member

pkosiec commented Nov 25, 2022

Description

This is a follow-up of #631. Slack App directory will unapprove our legacy Slack app on December 21st. It means that users will see a warning or be blocked from installing it, if not allowed with their workspace settings

  • Remove legacy Slack docs from docs.botkube.io and add deprecation notice - in Deprecate legacy Slack integration and fix replacing MS Teams version metadata botkube-docs#178

  • Remove configuration and logic for legacy Slack Extracted here

  • For Cloud: @huseyinbabal https://github.com/kubeshop/botkube-cloud/pull/560

    • add scopes column to API key database
    • manually create API key not connected to any deployment for test user (on Cloud Dev)
    • ensure it gets the custom scopes than deployment-related API key (in api key middleware)
    • use this API key to authenticate to Botkube Dev GraphQL API
  • Migrate E2E tests to Cloud Slack to make them able to run on CI: @huseyinbabal Cloud Slack E2e Tests #1205

    • We need to make sure the Cloud account have subscription enabled with Cloud Slack quota
    • Make sure this test can be run in parallel (we will still run it on PRs and main branch)
    • Rework some assertions
    • Move E2E RBAC and other configuration to cloud so that the test assertions work properly
  • Once all other items are finished, try to refactor Cloud Slack and Socket Slack to share same logic (so that it is tested with the tests) Extracted here

Blocked by

#1261

@pkosiec pkosiec added bug Something isn't working breaking Contains breaking change labels Nov 25, 2022
@pkosiec pkosiec added this to the v0.17.0 milestone Nov 25, 2022
@mszostok mszostok pinned this issue Dec 7, 2022
@mszostok mszostok mentioned this issue Dec 7, 2022
@pkosiec pkosiec modified the milestones: v0.17.0, v0.18.0 Jan 3, 2023
@pkosiec pkosiec modified the milestones: v0.19.0, v0.20.0 Feb 2, 2023
@pkosiec pkosiec modified the milestones: v1.1.0, v1.2.0 Apr 4, 2023
@pkosiec pkosiec modified the milestones: v1.1.0, v1.2.0, v1.3.0 Jun 20, 2023
@pkosiec pkosiec changed the title Deprecate legacy Slack integration Migrate legacy Slack tests to Cloud Slack Jul 18, 2023
@mashby2022 mashby2022 unpinned this issue Jul 18, 2023
@huseyinbabal huseyinbabal self-assigned this Aug 3, 2023
@pkosiec pkosiec modified the milestones: v1.3.0, v1.4.0 Aug 16, 2023
@pkosiec pkosiec modified the milestones: v1.4.0, v1.5.0 Sep 12, 2023
@pkosiec pkosiec closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Contains breaking change bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants