Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs to be moved to utils repo #9

Open
1 of 4 tasks
mengqiy opened this issue Jul 18, 2017 · 6 comments
Open
1 of 4 tasks

pkgs to be moved to utils repo #9

mengqiy opened this issue Jul 18, 2017 · 6 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@mengqiy
Copy link
Member

mengqiy commented Jul 18, 2017

These need to move out of k8s in order to cut kubectl out:

These should probably live in this repo, but are not required to move:

Ref: kubernetes/kubernetes#48209 (comment)

Feel free to edit the list above if you have more.

@nilebox
Copy link

nilebox commented Oct 10, 2017

We are also using k8s.io/kubernetes/pkg/util/configz in Service Catalog

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 8, 2018
@mengqiy
Copy link
Member Author

mengqiy commented Jan 8, 2018

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 8, 2018
@apelisse
Copy link
Member

apelisse commented Nov 19, 2020

These look reasonable to me. They're all part of fairly generic package names anyway (pkg/util), so it looks like they are fairly generic. One thing that is important is: are these used in multiple places? are they generally useful or are there some opinions hidden behind these names?

@ash2k
Copy link
Member

ash2k commented Jan 3, 2021

[ ] k8s.io/apimachinery/pkg/util/clock (see kubernetes/kubernetes#94738)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

7 participants