Move object diff and field path from apimachinery #82
Conversation
k8s-ci-robot
added
the
size/XL
sttts
force-pushed
the
sttts-move-diff-and-field-path
branch
from
38e5c32
to
8babdb0
Compare
k8s-ci-robot
added
the
cncf-cla: yes
| } | ||
|
|
||
| // ObjectReflectDiff returns a diff computed through reflection, without serializing to JSON. | ||
| func ObjectReflectDiff(a, b interface{}) string { |
There was a problem hiding this comment.
@smarterclayton will be happy to have this more available
There was a problem hiding this comment.
So am I! This fixes my request in #75.
|
both make sense to me for use outside k/k |
| "detect nil map": { | ||
| a: map[string]int(nil), | ||
| b: map[string]int{}, | ||
| out: ` |
There was a problem hiding this comment.
this is a great place to use dedent and not have wacky indenting in string literals.
There was a problem hiding this comment.
@sttts do you want to switch to dedent in this PR or a follow up?
There was a problem hiding this comment.
Would prefer a follow-up. This is a straight move.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
I have my doubts those details should be hidden. It makes a big difference how you extract a diff from objects. JSON is different from reflect. |
|
Perhaps the names should be more meaningfu, rather than
implementation-centric? Or perhaps we should find one-true format that we
can use everywhere.
…On Wed, Feb 13, 2019 at 3:06 AM Dr. Stefan Schimanski < ***@***.***> wrote:
The fact that the diff APIs expose their implementation details in their
names means we can probably never change these once we publish them. Are we
cool with that?
I have my doubts those details should be hidden. It makes a big difference
how you extract a diff from objects. JSON is different from reflect.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#82 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVJl-JCa8TiwjaQnYiBAUieybpbbcks5vM_HIgaJpZM4anGNN>
.
|
Both packages are not apimachinery specific, but totally generic (and e.g. useful in k/kube-openapi).