Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move apimachinery/pkg/util/diff to utils #75

Closed
rajathagasthya opened this issue Jan 28, 2019 · 3 comments
Closed

Move apimachinery/pkg/util/diff to utils #75

rajathagasthya opened this issue Jan 28, 2019 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@rajathagasthya
Copy link

We use that package in unit tests for some of our operators to generate diffs between actual and expected CR objects. If you think it's a good idea to add it to this repo, I'm happy to help!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2019
@thockin
Copy link
Member

thockin commented Apr 29, 2019 via email

@rajathagasthya
Copy link
Author

This is actually already implemented in #82. So I'll close this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants