Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spyglass doesn't load the build-log when the file is very large #32246

Open
smg247 opened this issue Mar 12, 2024 · 6 comments
Open

Spyglass doesn't load the build-log when the file is very large #32246

smg247 opened this issue Mar 12, 2024 · 6 comments
Labels
area/prow/deck Issues or PRs related to prow's deck component kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@smg247
Copy link
Contributor

smg247 commented Mar 12, 2024

What happened:
Spyglass doesn't load the 'Build Log' for an execution when the log is large. Instead it just spins until the browser kills it or the user gives up. Sometimes, it eventually loads, but after a very long time.

What you expected to happen:
The log will load within a reasonable amount of time.

How to reproduce it (as minimally and precisely as possible):
Navigate here and observe that the 'build log' section fails to load (or at least takes a very long time).

Please provide links to example occurrences, if any:
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6/1765598839164637184

Anything else we need to know?:
I believe this is due to the warning/error highlighting logic. We should make no attempt at doing this with log files over a certain size (1MB? 50,000 lines?).

@smg247 smg247 added the kind/bug Categorizes issue or PR as related to a bug. label Mar 12, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 12, 2024
@smg247
Copy link
Contributor Author

smg247 commented Mar 12, 2024

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 12, 2024
@smg247
Copy link
Contributor Author

smg247 commented Mar 12, 2024

/area prow/deck

@k8s-ci-robot k8s-ci-robot added the area/prow/deck Issues or PRs related to prow's deck component label Mar 12, 2024
@smg247
Copy link
Contributor Author

smg247 commented Mar 13, 2024

Perhaps we could just highlight errors/warnings found at the beginning and end of the logs in these cases. We could only look through the first and last 1,000 or so lines of the file.

@BenTheElder
Copy link
Member

I believe this is due to the warning/error highlighting logic. We should make no attempt at doing this with log files over a certain size (1MB? 50,000 lines?).

+1. We should also consider providing an error + log link over attempting to render it inline at all IMHO

@Vyom-Yadav
Copy link
Member

+1 for this, I've also faced this

@BenTheElder
Copy link
Member

Note: prow source code moved to kubernetes-sigs/prow and issues like this probably need to get re-filed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow/deck Issues or PRs related to prow's deck component kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

4 participants