Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs/e2e_node/containerd: Migrate deprecated [plugins."io.containerd.grpc.v1.cri".registry.mirrors] to config_path #31851

Open
Tracked by #9766
AkihiroSuda opened this issue Feb 6, 2024 · 9 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@AkihiroSuda
Copy link
Member

# Enable registry.k8s.io as the primary mirror for k8s.gcr.io
# See: https://github.com/kubernetes/k8s.io/issues/3411
[plugins."io.containerd.grpc.v1.cri".registry.mirrors."k8s.gcr.io"]
endpoint = ["https://registry.k8s.io", "https://k8s.gcr.io",]

[plugins."io.containerd.grpc.v1.cri".registry.mirrors] has been deprecated since containerd v1.5, and will be removed soon in containerd v2.0.

The replacement is config_path.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 6, 2024
@AkihiroSuda
Copy link
Member Author

/sig testing
/sig node

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 6, 2024
@BenTheElder
Copy link
Member

@kubernetes/sig-node-bugs

@AnishShah
Copy link

/priority important-longterm
/cc @chrishenzie

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 11, 2024
@ndixita
Copy link
Contributor

ndixita commented Mar 11, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Mar 11, 2024
@haircommander
Copy link
Contributor

looks like #31954 completed this
/close

@k8s-ci-robot
Copy link
Contributor

@haircommander: Closing this issue.

In response to this:

looks like #31954 completed this
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Node Bugs automation moved this from Triage to Done Mar 27, 2024
@haircommander
Copy link
Contributor

/reopen

actually, that was just one test job 🙃

@k8s-ci-robot k8s-ci-robot reopened this Mar 27, 2024
@k8s-ci-robot
Copy link
Contributor

@haircommander: Reopened this issue.

In response to this:

/reopen

actually, that was just one test job 🙃

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Node Bugs automation moved this from Done to Triage Mar 27, 2024
@haircommander haircommander moved this from Triage to Triaged in SIG Node Bugs Mar 27, 2024
@BenTheElder
Copy link
Member

the exclusive nature of the old and new fields makes migrating this a bit frustrating xref: kubernetes-sigs/kind#2875, it's too bad you can't begin using the new approach while migrating out of the old field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

No branches or pull requests

6 participants