Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a pagination for pr-history #31850

Open
dhiller opened this issue Feb 6, 2024 · 3 comments
Open

Have a pagination for pr-history #31850

dhiller opened this issue Feb 6, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@dhiller
Copy link
Contributor

dhiller commented Feb 6, 2024

What would you like to be added:
Have a pagination for pr-history.

Why is this needed:
On PRs with a lot of history requests are timing out with 504 status.

$ curl -v 'https://prow.ci.kubevirt.io/pr-history/?org=kubevirt&repo=kubevirt&pr=11054'                                 * processing: https://prow.ci.kubevirt.io/pr-history/?org=kubevirt&repo=kubevirt&pr=11054
*   Trying 169.59.29.65:443...
* Connected to prow.ci.kubevirt.io (169.59.29.65) port 443
* ALPN: offers h2,http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
*  CApath: none
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_128_GCM_SHA256
* ALPN: server did not agree on a protocol. Uses default.
* Server certificate:
*  subject: CN=prow.ci.kubevirt.io
*  start date: Feb  3 07:07:55 2024 GMT
*  expire date: May  3 07:07:54 2024 GMT
*  subjectAltName: host "prow.ci.kubevirt.io" matched cert's "prow.ci.kubevirt.io"
*  issuer: C=US; O=Let's Encrypt; CN=R3
*  SSL certificate verify ok.
* using HTTP/1.x
> GET /pr-history/?org=kubevirt&repo=kubevirt&pr=11054 HTTP/1.1
> Host: prow.ci.kubevirt.io
> User-Agent: curl/8.2.1
> Accept: */*
> 
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* old SSL session ID is stale, removing
< HTTP/1.1 504 Gateway Time-out
< content-length: 92
< cache-control: no-cache
< content-type: text/html
< 
<html><body><h1>504 Gateway Time-out</h1>
The server didn't respond in time.
</body></html>
* Connection #0 to host prow.ci.kubevirt.io left intact
@dhiller dhiller added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 6, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Feb 6, 2024

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 6, 2024
dhiller added a commit to dhiller/project-infra that referenced this issue Feb 6, 2024
@dhiller
Increase resources for deck deployment to lower 504 risk
0d6f3c3 
For PRs that have a lot of history the pr-history page has a risk of
timing out with a 504 error.

I.e. https://prow.ci.kubevirt.io/pr-history/?org=kubevirt&repo=kubevirt&pr=11054

Increase the CPU limit to raise the chance of the call being successful.

Note: kubernetes/test-infra issue created here
kubernetes/test-infra#31850

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@dhiller dhiller mentioned this issue Feb 6, 2024
Merged
8 tasks
kubevirt-bot pushed a commit to kubevirt/project-infra that referenced this issue Feb 6, 2024
@dhiller
Increase resources for deck deployment to lower 504 risk (#3235)
e59ad64 
For PRs that have a lot of history the pr-history page has a risk of
timing out with a 504 error.

I.e. https://prow.ci.kubevirt.io/pr-history/?org=kubevirt&repo=kubevirt&pr=11054

Increase the CPU limit to raise the chance of the call being successful.

Note: kubernetes/test-infra issue created here
kubernetes/test-infra#31850

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@BenTheElder
Copy link
Member

GitHub also struggles to render PRs like this ... I'd suggest re-filing the PR

Barakmor1 pushed a commit to Barakmor1/project-infra that referenced this issue Apr 24, 2024
@dhiller @Barakmor1
Increase resources for deck deployment to lower 504 risk (kubevirt#3235)
7617010 
For PRs that have a lot of history the pr-history page has a risk of
timing out with a 504 error.

I.e. https://prow.ci.kubevirt.io/pr-history/?org=kubevirt&repo=kubevirt&pr=11054

Increase the CPU limit to raise the chance of the call being successful.

Note: kubernetes/test-infra issue created here
kubernetes/test-infra#31850

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dhiller @BenTheElder @k8s-ci-robot @k8s-triage-robot