Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added case for rerun job for expried failed workflow #31739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added case for rerun job for expried failed workflow #31739

wants to merge 1 commit into from
+69 −5

Conversation

AvineshTripathi
Copy link

@AvineshTripathi AvineshTripathi commented Jan 26, 2024 •
edited

fixes #31645

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2024
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow area/prow/hook Issues or PRs related to prow's hook component area/prow/plugins Issues or PRs related to prow's plugins for the hook component sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 26, 2024
@AvineshTripathi AvineshTripathi marked this pull request as draft January 26, 2024 14:10
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2024
@AvineshTripathi AvineshTripathi marked this pull request as ready for review January 26, 2024 14:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2024
@AvineshTripathi
Copy link
Author

/retest

MadhavJivrajani
MadhavJivrajani reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AvineshTripathi! ❤️

Leaving a few initial comments.

prow/github/client.go Outdated Show resolved Hide resolved
prow/plugins/trigger/generic-comment.go Show resolved Hide resolved
prow/plugins/trigger/generic-comment.go Outdated Show resolved Hide resolved
prow/plugins/trigger/generic-comment.go Outdated Show resolved Hide resolved
prow/plugins/trigger/generic-comment.go Outdated Show resolved Hide resolved
prow/plugins/trigger/generic-comment.go Outdated Show resolved Hide resolved
petr-muller
petr-muller reviewed Jan 30, 2024
View reviewed changes
prow/plugins/trigger/generic-comment.go Outdated Show resolved Hide resolved
prow/plugins/trigger/generic-comment_test.go Outdated Show resolved Hide resolved
prow/plugins/trigger/generic-comment_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2024
@AvineshTripathi
Copy link
Author

Hey @MadhavJivrajani please have a look at this PR. Thanks!

MadhavJivrajani
MadhavJivrajani requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping @AvineshTripathi, this had dropped off my radar.
Just one comment, LGTM after that!

prow/plugins/trigger/generic-comment_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 27, 2024
@k8s-ci-robot k8s-ci-robot added area/jobs area/provider/azure Issues or PRs related to azure provider area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Mar 4, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AvineshTripathi
Once this PR has been reviewed and has the lgtm label, please assign droslean for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AvineshTripathi
Copy link
Author

@MadhavJivrajani not sure if I can do anything to fix this Pod scheduling timeout

@MadhavJivrajani
Copy link
Contributor

/retest
@AvineshTripathi don't worry about it! I think the test cluster should be fine now.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 5, 2024 •
edited

@AvineshTripathi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-gubernator 16465d7 link true /test pull-test-infra-gubernator
pull-test-infra-prow-checkconfig 16465d7 link true /test pull-test-infra-prow-checkconfig

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AvineshTripathi @MadhavJivrajani
added case for rerun job for expried failed workflow
b62deb5 
Co-authored-by: Madhav Jivrajani <12381034+MadhavJivrajani@users.noreply.github.com>
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2024
@jihoon-seo
Copy link
Member

Hello @AvineshTripathi, the Prow source code has been moved to https://github.com/kubernetes-sigs/prow on April 9, 2024.
Please consider migrate this PR (by opening a new one in there).
Thanks!

/remove-area config jobs provider/azure provider/gcp release-eng
/remove-sig cloud-provider cluster-lifecycle release storage

@k8s-ci-robot k8s-ci-robot removed area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner Awaiting requested review from cjwagner

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

@jmguzik jmguzik Awaiting requested review from jmguzik

@petr-muller petr-muller Awaiting requested review from petr-muller

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

Assignees

@MadhavJivrajani MadhavJivrajani

Labels
area/prow/hook Issues or PRs related to prow's hook component area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prow: handle the case of re-triggering an expired GitHub workflow
5 participants
@AvineshTripathi @MadhavJivrajani @k8s-ci-robot @jihoon-seo @petr-muller