From d72926d4915133550e41de1252fe2a4aa0aa3745 Mon Sep 17 00:00:00 2001 From: Marc Khouzam Date: Fri, 4 Nov 2022 16:57:24 -0400 Subject: [PATCH] Enable shell completion descriptions for bash Cobra provides support for completion descriptions for bash. It was turned off because of a bug with certain bash menu options which have been fixed by Cobra 1.3.0. Signed-off-by: Marc Khouzam --- staging/src/k8s.io/kubectl/pkg/cmd/completion/completion.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/staging/src/k8s.io/kubectl/pkg/cmd/completion/completion.go b/staging/src/k8s.io/kubectl/pkg/cmd/completion/completion.go index 2f1ba8d054a8..f9f27fe662fa 100644 --- a/staging/src/k8s.io/kubectl/pkg/cmd/completion/completion.go +++ b/staging/src/k8s.io/kubectl/pkg/cmd/completion/completion.go @@ -167,7 +167,7 @@ func runCompletionBash(out io.Writer, boilerPlate string, kubectl *cobra.Command return err } - return kubectl.GenBashCompletionV2(out, false) // TODO: Upgrade to Cobra 1.3.0 or later before including descriptions (See https://github.com/spf13/cobra/pull/1509) + return kubectl.GenBashCompletionV2(out, true) } func runCompletionZsh(out io.Writer, boilerPlate string, kubectl *cobra.Command) error {