-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InPlacePodVerticalScaling] ResizePolicy field is not being validated #116854
Comments
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @vinaykul |
I'll try this for v1.27 if you don't mind. |
getting a PR open, reviewed, and green is always good. we'll evaluate it for risk and if there's a second release candidate we can likely include it |
Nice catch! Please review fix: #116857 This likely got dropped either during port-over of the original PR or during bad rebase. I should not have left the resize policy e2e tests for beta. Gotta run to get my kid prepped, dr. appt and then school drop. So I'll try and add an E2E test for this later today. please hold for e2e test (but we should fix this in 1.27) |
@gjkim42 I realized you were working on a fix as well only after I sent my fix out and was catching up on emails at doc office (rushed morning). I didn't mean to step over your effort to fix it, sorry about that. |
I am completely fine with that. Thanks for the fix :) |
What happened?
#102884 (comment)
The newly added field
ResizePolicy
field is not being validated.@vinaykul @liggitt
What did you expect to happen?
ResizePolicy
field should be validated.How can we reproduce it (as minimally and precisely as possible)?
We can create a pod with invalid
ResizePolicy
to reproduce this.Anything else we need to know?
No response
Kubernetes version
Cloud provider
OS version
Install tools
Container runtime (CRI) and version (if applicable)
Related plugins (CNI, CSI, ...) and versions (if applicable)
The text was updated successfully, but these errors were encountered: