Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InPlacePodVerticalScaling] ResizePolicy field is not being validated #116854

Closed
gjkim42 opened this issue Mar 22, 2023 · 7 comments · Fixed by #116857
Closed

[InPlacePodVerticalScaling] ResizePolicy field is not being validated #116854

gjkim42 opened this issue Mar 22, 2023 · 7 comments · Fixed by #116857
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone

Comments

@gjkim42
Copy link
Member

gjkim42 commented Mar 22, 2023

What happened?

#102884 (comment)

The newly added field ResizePolicy field is not being validated.

@vinaykul @liggitt

What did you expect to happen?

ResizePolicy field should be validated.

How can we reproduce it (as minimally and precisely as possible)?

We can create a pod with invalid ResizePolicy to reproduce this.

Anything else we need to know?

No response

Kubernetes version

$ kubectl version
# paste output here

Cloud provider

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

@gjkim42 gjkim42 added the kind/bug Categorizes issue or PR as related to a bug. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt
Copy link
Member

liggitt commented Mar 22, 2023

/assign @vinaykul
/sig node
/priority important-soon
/milestone v1.27
adding to 1.27 milestone to resolve if possible

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 22, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 22, 2023
@gjkim42
Copy link
Member Author

gjkim42 commented Mar 22, 2023

I'll try this for v1.27 if you don't mind.

@liggitt
Copy link
Member

liggitt commented Mar 22, 2023

getting a PR open, reviewed, and green is always good. we'll evaluate it for risk and if there's a second release candidate we can likely include it

@vinaykul
Copy link
Contributor

vinaykul commented Mar 22, 2023

Nice catch! Please review fix: #116857

This likely got dropped either during port-over of the original PR or during bad rebase. I should not have left the resize policy e2e tests for beta.

Gotta run to get my kid prepped, dr. appt and then school drop. So I'll try and add an E2E test for this later today. please hold for e2e test (but we should fix this in 1.27)

@vinaykul
Copy link
Contributor

@gjkim42 I realized you were working on a fix as well only after I sent my fix out and was catching up on emails at doc office (rushed morning). I didn't mean to step over your effort to fix it, sorry about that.

@gjkim42
Copy link
Member Author

gjkim42 commented Mar 22, 2023

I am completely fine with that. Thanks for the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
Archived in project
4 participants