Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kms as to 1.26 rules for multiple components #114353

Conversation

dims
Copy link
Member

@dims dims commented Dec 8, 2022

In 576cca0, we fixed one spot, looks like we need to do the same for others!

Please see #114335 for more context

Signed-off-by: Davanum Srinivas davanum@gmail.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


In 576cca0, we fixed one spot, looks
like we need to do the same for others!

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 8, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.26 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.26.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Dec 7 23:57:34 UTC 2022.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 8, 2022
@k8s-ci-robot
Copy link
Contributor

@dims: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 8, 2022
@dims
Copy link
Member Author

dims commented Dec 8, 2022

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 8, 2022
@dims
Copy link
Member Author

dims commented Dec 8, 2022

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 8, 2022
@dims
Copy link
Member Author

dims commented Dec 8, 2022

looks much better (1.26 and master references match)

[davanum@c889f3bd53ed 19:32] ~/go/src/k8s.io/kubernetes/staging/publishing ⟩ rg -i -e "destination: " -e "repository: kms"
rules.yaml
2:- destination: code-generator
33:- destination: apimachinery
65:- destination: api
115:- destination: client-go
201:- destination: component-base
275:- destination: component-helpers
349:- destination: kms
361:- destination: apiserver
373:    - repository: kms
445:    - repository: kms
451:- destination: kube-aggregator
465:    - repository: kms
559:    - repository: kms
564:- destination: sample-apiserver
578:    - repository: kms
697:    - repository: kms
707:- destination: sample-controller
822:- destination: apiextensions-apiserver
838:    - repository: kms
940:    - repository: kms
947:- destination: metrics
1033:- destination: cli-runtime
1107:- destination: sample-cli-plugin
1192:- destination: kube-proxy
1278:- destination: kubelet
1364:- destination: kube-scheduler
1450:- destination: controller-manager
1464:    - repository: kms
1546:    - repository: kms
1552:- destination: cloud-provider
1570:    - repository: kms
1672:    - repository: kms
1678:- destination: kube-controller-manager
1698:    - repository: kms
1810:    - repository: kms
1816:- destination: cluster-bootstrap
1878:- destination: csi-translation-lib
1940:- destination: mount-utils
1972:- destination: legacy-cloud-providers
1994:    - repository: kms
2126:    - repository: kms
2132:- destination: cri-api
2164:- destination: kubectl
2298:- destination: pod-security-admission
2312:    - repository: kms
2394:    - repository: kms
2400:- destination: dynamic-resource-allocation

@liggitt
Copy link
Member

liggitt commented Dec 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2022
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, nikhita, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member Author

dims commented Dec 8, 2022

@kubernetes/release-team-leads @kubernetes/release-managers Since we really need the bot to work, we need to merge this for 1.26, applying milestone.

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Dec 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7cba7e6 into kubernetes:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants