Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update logtools to support verbosity Zero Check #112206

Closed
yangjunmyfm192085 opened this issue Sep 2, 2022 · 7 comments
Closed

update logtools to support verbosity Zero Check #112206

yangjunmyfm192085 opened this issue Sep 2, 2022 · 7 comments
Assignees
@yangjunmyfm192085
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.

Comments

@yangjunmyfm192085
Copy link
Contributor

What would you like to be added?

as discussed in kubernetes-sigs/logtools#2 and #111708, we should add verbosity Zero Check in logtools

Why is this needed?

because with V(0) and without V(0) semantically equivalent and V(0) add some (small) overhead
E.g:
klog.V(0).InfoS and klog.InfoS are equivalent. We don't need to use klog.V(0).InfoS
@yangjunmyfm192085 yangjunmyfm192085 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 2, 2022
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 2, 2022
@yangjunmyfm192085
Copy link
Contributor Author

/cc @pohly

@yangjunmyfm192085
Copy link
Contributor Author

/sig instrumentation
/wg structured-logging

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 2, 2022
@pohly
Copy link
Contributor

pohly commented Sep 2, 2022

Let's do a new logtools release once kubernetes-sigs/logtools#1 is merged. I want to avoid bothering approvers multiple times with smallish updates to the hack/tools directory.

@yangjunmyfm192085 yangjunmyfm192085 mentioned this issue Sep 3, 2022
Closed
@dashpole
Copy link
Contributor

dashpole commented Sep 8, 2022

/assign yangjunmyfm192085
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 8, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 7, 2022
@vaibhav2107
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 8, 2022
@yangjunmyfm192085
Copy link
Contributor Author

Implemented in #115060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangjunmyfm192085 yangjunmyfm192085

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update logtools to support verbosity Zero Check yangjunmyfm192085/kubernetes
6 participants
@pohly @dashpole @k8s-ci-robot @k8s-triage-robot @yangjunmyfm192085 @vaibhav2107